Bugs item #1701207, was opened at 2007-04-15 17:45 Message generated for change (Comment added) made by nnorwitz You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=105470&aid=1701207&group_id=5470
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Python Interpreter Core >Group: Python 2.5 >Status: Closed Resolution: None >Priority: 5 Private: No Submitted By: ajrh (ajrh) Assigned to: Neal Norwitz (nnorwitz) Summary: svnversion_init assertion failed Initial Comment: python: src/python-2.5.1c1/Python/sysmodule.c:1000: svnversion_init: Assertion `len >= 13' failed. I see these assertions were added here: http://mail.python.org/pipermail/python-checkins/2006-October/057079.html Given the form of the subversion headurl string, the assertion doesn't appear to me at first glance to be valid. ---------------------------------------------------------------------- >Comment By: Neal Norwitz (nnorwitz) Date: 2007-04-16 00:40 Message: Logged In: YES user_id=33168 Originator: NO Committed revision 54841. (trunk) I think I'll just leave this out of 2.5 given how badly I botched this the first time. I did test this and ensure that both branches worked this time. For the first block, I triggered istag by adding tag to the headurl. For the second block I #undef SVNVERSION in Modules/getbuildinfo.c to verify the exported version works too. ---------------------------------------------------------------------- Comment By: Neal Norwitz (nnorwitz) Date: 2007-04-15 23:13 Message: Logged In: YES user_id=33168 Originator: NO Committed revision 54836. (2.5) - Remove the 2 assertions. I still need to fix up head. I also noticed I botched the second assert. - should be +. I'll test this and verify the fix before fixing head. ---------------------------------------------------------------------- Comment By: Neal Norwitz (nnorwitz) Date: 2007-04-15 23:09 Message: Logged In: YES user_id=33168 Originator: NO Anthony agreed that the assert should be removed for 2.5.1. ---------------------------------------------------------------------- Comment By: Neal Norwitz (nnorwitz) Date: 2007-04-15 22:34 Message: Logged In: YES user_id=33168 Originator: NO Unfortunately I don't recall. Looking at the code, my guess is that I added the assertion into the wrong code block. The next code block down requires len >= 13. I'll move it on head, shall I remove it for 2.5.1, then add it back in the proper place for 2.5.2? ---------------------------------------------------------------------- Comment By: Martin v. Löwis (loewis) Date: 2007-04-15 22:03 Message: Logged In: YES user_id=21627 Originator: NO Neal, can you take a look? The assert really does not make sense to me. How did you arrive at 13? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=105470&aid=1701207&group_id=5470 _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
