Éric Araujo <mer...@netwok.org> added the comment:
Hi! I cleaned up your patch and fixed a bug: you have to call sort before
calling remove_duplicates (the result in your patch had two 'a' entries).
> One line was marked as excluded because it was a "this cannot happen"
> error, and I agreed.
How about we add a test to make this it cannot happen and then remove the line?
I also ported it to packaging, the replacement for distutils; I get this
failure:
FAIL: test_process_template (__main__.ManifestTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
File "Lib/packaging/tests/test_manifest.py", line 166, in
test_process_template
action)
AssertionError: PackagingTemplateError not raised by _process_template_line
I haven’t investigated if the test is wrong or the code buggy yet; do you have
any insight?
----------
status: pending -> open
title: Increase distutils.filelist test coverage -> Increase distutils.filelist
/ packaging.manifest test coverage
versions: -Python 3.1
Added file: http://bugs.python.org/file22230/distutils-filelist.diff
_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue11751>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
