STINNER Victor <victor.stin...@haypocalc.com> added the comment:

Remarks about test_wconsole_binlarge.patch:
 - I don't know if isatty() is cheap or not. Is it a system call? If it might 
be slow, it should be only be called once in the constructor. On Windows, I 
don't think that isatty(fd) evoles.
 - I don't want to commit the tests because they write 66000 * 2 characters to 
the test output, which floods the test output. I don't know how to create a 
fake stdout which is a TTY but not the real stdout, especially on Windows. I 
think that manual tests only once should be enough. Or does anyone know how to 
create a fake TTY output?

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue11395>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to