Ezio Melotti <ezio.melo...@gmail.com> added the comment: Some buildbots are failing after the commit.
Also in the crypt.py module I still see things that according to msg126453 should be fixed already: * more statements on the same line (e.g. "if salt == None: salt = mksalt()"); * the hardcoded salt values instead of string.ascii_letters; According to the PEP8 there shouldn't be any spaces after the '[' and before the ']' (e.g. "method_list = [ METHOD_SHA512, METHOD_SHA256, METHOD_MD5 ]" and in the listcomps) and around the = in the function/method declarations/calls (e.g. "def crypt(word, salt = None):"). ---------- keywords: +buildbot nosy: +ezio.melotti _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue10924> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com