rep <m...@mwcollect.org> added the comment: Xuanji: Patch looks good now with the test cases.
Regarding the other fix suggested by Kevin I think that we should not introduce custom behaviour here like appending the eofdata to the comment even though the comment size in the record does not say so. In the end we want to make sure that correct zip files end up being processed correctly with the specified comment size and incorrect zip files with eofdata should not be rejected / throw exceptions. So I agree with Xuanji that his patch (or mine) is the way to go. You probably agree that we can mark issue 10298 to be superseded by this one here. ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue10694> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
