Alexander Belopolsky <belopol...@users.sourceforge.net> added the comment:

I would say if anything can go in after rc2 at all, this should be accepted.  
George?

I ran a few sanity checks with the patch applied:

>>> set(struct.__all__) - set(dir(struct))
set()
>>> set(dir(struct)) - set(struct.__all__)
{'_clearcache', '__all__', '__builtins__', '__file__', '__package__', 
'__cached__', '__name__', '__doc__'}
>>> len(set(struct.__all__)) == len(struct.__all__)
True

LGTM.  Maybe one of the tests above can be converted to a unit test.

----------
assignee:  -> georg.brandl
versions: +Python 3.2 -Python 3.3

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue11081>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to