Bugs item #1178141, was opened at 2005-04-06 23:48 Message generated for change (Comment added) made by barry-scott You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=105470&aid=1178141&group_id=5470
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Python Library Group: Python 2.3 Status: Open Resolution: None Priority: 5 Submitted By: Barry Alan Scott (barry-scott) Assigned to: Nobody/Anonymous (nobody) Summary: urllib.py overwrite HTTPError code with 200 Initial Comment: I found this bug while trying to understand why a 404 Not Found error was reported as a 200 Not Found. Turns out the HTTPError's self.code is overwritten with 200 after the 404 was correctly assigned. The attached patch fixes the problem. ---------------------------------------------------------------------- >Comment By: Barry Alan Scott (barry-scott) Date: 2006-02-22 20:17 Message: Logged In: YES user_id=28665 There are two problems. 1) 200-299 are all good, not just 200 2) Setting the code in addinfourl needs to use the 2xx code that came from the server I have a complex http app that broken without this fix. I'm doing partial transfers that return 206 that was being overwritten. This is clearly a bug. The only issue is does the patch fix the bug and not cause other problems? In nearly a year of running with this patch on 700 systems I've not seen a problem. ---------------------------------------------------------------------- Comment By: Georg Brandl (gbrandl) Date: 2006-02-22 11:32 Message: Logged In: YES user_id=849994 Okay, reopening. ---------------------------------------------------------------------- Comment By: Jim Jewett (jimjjewett) Date: 2006-02-20 21:53 Message: Logged In: YES user_id=764593 Barry -- Are you sure that the original status code wasn't 204? If so, then this patch makes more sense. Georg -- any unrecognized response status NXX should be treated as N00. Since 204 (and 298, for that matter) aren't recognized by the urllib opener, they should be treated as 200, which the patch does. Whether the patch makes it harder to treat 204 separately when it is recognized is another issue. ---------------------------------------------------------------------- Comment By: Georg Brandl (gbrandl) Date: 2006-02-20 21:30 Message: Logged In: YES user_id=849994 I cannot see the point of the patch and cannot reproduce the error. ---------------------------------------------------------------------- Comment By: Jim Jewett (jimjjewett) Date: 2005-04-08 17:18 Message: Logged In: YES user_id=764593 Please reattach (SF didn't catch the file) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=105470&aid=1178141&group_id=5470 _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
