On Tue, 17 Oct 2017, A. Coady (JIRA) wrote:

A. Coady created PYLUCENE-38:
--------------------------------

            Summary: JCC build error under recents versions of clang.
                Key: PYLUCENE-38
                URL: https://issues.apache.org/jira/browse/PYLUCENE-38
            Project: PyLucene
         Issue Type: Bug
        Environment: macOS
           Reporter: A. Coady


{code:none}
jcc3/sources/JArray.cpp:315:66: error: ordered comparison between pointer and 
zero ('PyObject *' (aka '_object *') and 'int')
       PyList_Type.tp_as_sequence->sq_inplace_concat(list, arg) < 0)
       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
jcc3/sources/JArray.cpp:330:64: error: ordered comparison between pointer and 
zero ('PyObject *' (aka '_object *') and 'int')
       PyList_Type.tp_as_sequence->sq_inplace_repeat(list, n) < 0)
       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
{code}

Comparisons between NULL and integers have been elevated from a warning to an error in recent versions of clang. And presumably the error handling wasn't working anyway.

Indeed. These return NULL on error, not < 0.
Thank you for the bug report. This is fixed in rev 1812455.

Andi..




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to