On Thu, 12 May 2011, Christian Heimes wrote:
JCC 2.7 broke exclusion of inner classes. It's no longer possible to
exclude an inner class like
--exclude com.browseengine.bobo.facets.FacetHandler$TermCountSize
We exclude the inner class because it breaks MSVC on Windows with an
obscure error message. Since we don't need the inner class in Python, I
excluded it. JCC 2.7 and 2.8 ignore the pattern, because they check for
"className.split('$', 1)[0] in excludes" and no longer for "className in
excludes". The small patch fixes the problem.
Indeed.
Thank you for patch.
How's yesterday's issue's patch doing ?
Is it reliable enough ?
Andi..
Christian
Index: jcc/cpp.py
===================================================================
--- jcc/cpp.py (revision 1088091)
+++ jcc/cpp.py (working copy)
@@ -199,7 +199,7 @@
cls = cls.getComponentType()
className = cls.getName()
- if className.split('$', 1)[0] in excludes:
+ if className.split('$', 1)[0] in excludes or className in excludes:
return False
if cls.isPrimitive():
@@ -544,7 +544,7 @@
packages.add('java.lang')
for className in classNames:
- if className.split('$', 1)[0] in excludes:
+ if className.split('$', 1)[0] in excludes or className in
excludes:
continue
cls = findClass(className.replace('.', '/'))
if Modifier.isPublic(cls.getModifiers()):
