That looks to be correct. I'll see if I can get a new beta out with that fix later tonight. I may change up how the if/else statements there to make it more clear what is going on.
Bert > On Jan 2, 2019, at 09:39, Michael Merickel <[email protected]> wrote: > > I suspect you can ignore the warning and that it is a bug. > > It seems likely that this [1] should be "if data and not > self.logged_write_no_body" to avoid warning when the body is missing on a > response that may contain a body? > > [1] > https://github.com/Pylons/waitress/blob/01ae68065f46b7b04950255882f129d770a9645b/waitress/task.py#L351 > > <https://github.com/Pylons/waitress/blob/01ae68065f46b7b04950255882f129d770a9645b/waitress/task.py#L351> > On Wed, Jan 2, 2019 at 10:14 AM Lele Gaifax <[email protected] > <mailto:[email protected]>> wrote: > Hi, > > Bert JW Regeer <[email protected] <mailto:[email protected]>> writes: > > > I am hoping to get some feedback from testing, if you can > > I installed waitress 1.2.0b1 in an application I'm developing, and the only > "suspicious" thing I noticed is the following warning log, that popups quite > often: > > waitress: application-written content was ignored due to HTTP response that > may not contain a message-body: (200 OK) > > Putting a debugger in task.py::Task.write(), I see the following backtrace > > /usr/local/lib/python3.6/threading.py(884)_bootstrap() > -> self._bootstrap_inner() > /usr/local/lib/python3.6/threading.py(916)_bootstrap_inner() > -> self.run() > /usr/local/lib/python3.6/threading.py(864)run() > -> self._target(*self._args, **self._kwargs) > > /usr/local/lib/python3.6/site-packages/waitress/task.py(78)handler_thread() > -> task.service() > /usr/local/lib/python3.6/site-packages/waitress/channel.py(336)service() > -> task.service() > /usr/local/lib/python3.6/site-packages/waitress/task.py(175)service() > -> self.execute() > /usr/local/lib/python3.6/site-packages/waitress/task.py(469)execute() > -> self.write(b'') # generate headers > > /usr/local/lib/python3.6/site-packages/waitress/task.py(353)write() > -> self.logger.warning( > > Is it expected? > > Thank you, > ciao, lele. > -- > nickname: Lele Gaifax | Quando vivrò di quello che ho pensato ieri > real: Emanuele Gaifas | comincerò ad aver paura di chi mi copia. > [email protected] <mailto:[email protected]> | -- > Fortunato Depero, 1929. > > -- > You received this message because you are subscribed to the Google Groups > "pylons-discuss" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected] > <mailto:pylons-discuss%[email protected]>. > To post to this group, send email to [email protected] > <mailto:[email protected]>. > To view this discussion on the web visit > https://groups.google.com/d/msgid/pylons-discuss/8736qbavgg.fsf%40metapensiero.it > > <https://groups.google.com/d/msgid/pylons-discuss/8736qbavgg.fsf%40metapensiero.it>. > For more options, visit https://groups.google.com/d/optout > <https://groups.google.com/d/optout>. > > -- > You received this message because you are subscribed to the Google Groups > "pylons-discuss" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected] > <mailto:[email protected]>. > To post to this group, send email to [email protected] > <mailto:[email protected]>. > To view this discussion on the web visit > https://groups.google.com/d/msgid/pylons-discuss/CAKdhhwF9YMW5dKZLeCz%3DLx4mR_wGvj2_AZBeXbtMgxGAhOxs0g%40mail.gmail.com > > <https://groups.google.com/d/msgid/pylons-discuss/CAKdhhwF9YMW5dKZLeCz%3DLx4mR_wGvj2_AZBeXbtMgxGAhOxs0g%40mail.gmail.com?utm_medium=email&utm_source=footer>. > For more options, visit https://groups.google.com/d/optout > <https://groups.google.com/d/optout>. -- You received this message because you are subscribed to the Google Groups "pylons-discuss" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/pylons-discuss/52FD77F3-8DA3-4E7D-8CED-60BBC34F3C5D%400x58.com. For more options, visit https://groups.google.com/d/optout.
