Am Donnerstag, 23. April 2009 00:11:33 schrieb Christoph Haas: > Am Samstag, 11. April 2009 15:59:46 schrieb KLEIN Stéphane: > > In webhelpers.paginate module, I wonder why "_pagelink" and "_range" > > function > > are defined in "pager" function and not in "Page" class ? > > > > Personnally, I need to override "_pagelink" function, with current > > implementation I need to paste all "pager" function in my sub page > > class. > > > > Can I send to you a patch with "_pagelink" and "_range" function moved > > to "Page" > > class ? > > Please do that if you managed to do move the functions around. I > understand that you want to override the functions more easily but in > the code it's not that trivial. Page.pager() calls _range() which in > turn calls _pagerlink. And _pagerlink needs quite a few parameters from > pager(). So the correct way would be to pass through all these variables > on every call. I have started to do that but the code becomes less > readable so that I wonder if it's worth it. > > Let me know if you have a niftier patch than what I did.
Sorry for the noise. Just found your patch at http://paste.pocoo.org/show/113226/ and will look into it. Thanks for the contribution. Christoph
signature.asc
Description: This is a digitally signed message part.
