It is moving the following logic into its own separate methods: * which guests are included in a vzdump job adds missing `all` and `exclude` handling.
* which volumes / mountpoints of a guest are included changes from v5 to v6: * incorporated suggested improvements changes from v4[1] to v5: * incorporate feedback * extend tests to `all` and `exclude` more in the individual patches changes from v3[5] to v4: * rework guest include logic in manager * fix changed function call in QemuConfig.pm [1] https://pve.proxmox.com/pipermail/pve-devel/2020-April/042753.html [5] https://pve.proxmox.com/pipermail/pve-devel/2020-March/042420.htmli manager: Aaron Lauterer (2): vzdump: move remaining guest include logic to single method vzdump: test: adapt and add more tests that are possible now PVE/API2/VZDump.pm | 19 +++-- PVE/VZDump.pm | 80 +++++++++---------- test/vzdump_guest_included_test.pl | 123 ++++++++++++++--------------- 3 files changed, 108 insertions(+), 114 deletions(-) qemu-server: Aaron Lauterer (1): vzdump: move include logic for volumes to method PVE/QemuConfig.pm | 31 ++++++++++++++++++++++++++++ PVE/VZDump/QemuServer.pm | 44 +++++++++++++++++++++------------------- 2 files changed, 54 insertions(+), 21 deletions(-) container: Aaron Lauterer (2): vzdump: add reason for mountpoint backup inclusion vzdump: move include logic for mountpoints to method src/PVE/LXC/Config.pm | 48 ++++++++++++++++++++++++++++++++++++------- src/PVE/VZDump/LXC.pm | 25 ++++++++++++++-------- 2 files changed, 57 insertions(+), 16 deletions(-) -- 2.20.1 _______________________________________________ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel