This patchset fixes #2777. Changes v1 -> v2: * stable paths are now selected where they belong - in the backend * this made the frontend changes unnecessary * added a patch to show the model (and not only the serial) in the ZFS creation dialogue
Cover letter from v1: Creating zpools should be done using the more stable device paths instead of /dev/sdX. The case where this was reported was: * hotplugging 2 disks in a server * creating the zpool * rebooting (the disks got new assignments) so a not too unusual use-case. The logic for selecting the by-id link worked in my tests, and on my machine. One alternative would be to not remove the wwn/eui links - functionality wise it should work with them as well. The fallback to the regular device-path was kept since we cannot assume that all disks get a by-id path (learned from our installer and virtio-block devices). The manager patches could probably be squashed - can gladly send a v2 but am fine if you squash them while applying. pve-storage: Stoiko Ivanov (1): fix #2777 create zpools with stable dev paths PVE/API2/Disks/ZFS.pm | 3 +++ PVE/Diskmanage.pm | 8 ++++++++ test/disk_tests/sas/disklist_expected.json | 3 ++- 3 files changed, 13 insertions(+), 1 deletion(-) pve-manager: Stoiko Ivanov (1): add model information to ZFS create window www/manager6/node/ZFS.js | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) -- 2.20.1 _______________________________________________ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel