On 4/27/20 12:29 PM, Dominik Csapak wrote: > > > On 4/27/20 12:15 PM, Thomas Lamprecht wrote: >> On 4/9/20 4:10 PM, Dominik Csapak wrote: >>> opens a window with the parameters for the sync and two buttons: >>> 'preview' and 'sync' >>> >>> both open the taskviewer, but the 'preview' one sets the 'no-write' >>> parameter so that it does not get written out to the user.cfg >>> >>> Signed-off-by: Dominik Csapak <d.csa...@proxmox.com> >>> --- >>> www/manager6/Makefile | 1 + >>> www/manager6/dc/AuthView.js | 21 ++++++ >>> www/manager6/dc/SyncWindow.js | 125 ++++++++++++++++++++++++++++++++++ >>> 3 files changed, 147 insertions(+) >>> create mode 100644 www/manager6/dc/SyncWindow.js >> >> >> Works OK, after the s/no-write/dry-run/ fix which was required to a change to >> the API patch coming after you sent this one - obviously. >> >> Some UX changes I'd like to see though, mainly regarding the default sync >> options. >> I'd like to have their values visible in the Realm Sync window and ideally, >> if a >> non-optional property is not set in the default-sync-options we should >> require that >> one. > > make sense > >> >> For display the value(s) of the default-sync-options for this realm we could >> either >> add another section at the top of the window, having all set fields there >> (or a >> "emptyText"-like "No default-sync-option set", if none). > > i'd rather go with the emptyText here (otherwise we have each field twice, > one field and one display, which i would find confusing)
I don't think you understood me, the emptyText belonged to the show sync options as fields, it was meant as the emptyText for that whole section, so the "" ^^ But anyway, however you think it's shown best, I would like you to just have the following two points in mind: * user must know what configuration params are really used for the sync * user must know beforehand when they need to specify something, i.e., if it's not optional and not in the default-sync-options > >> >> An alternative could be to show it after the "Default". Oh, and the "Enable >> new" >> default entry "Yes (Default)" can be really confusing, because if one set the >> sync-options to "do not enable new" this would do the opposite the user got >> told. >> _______________________________________________ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
