On 1/21/20 1:53 PM, Fabian Grünbichler wrote: > pve-manager: > > Fabian Grünbichler (9):
> www: add 'users' columns to Groups model > www: add permissions button to userview > www: add Token Panel + Edit Window > www: add Token to ACL > www: add TokenView with fixed userid > Applied those one now too, but with some real heavy followup. Went for a more schematic approach, albeit it could be still improved with moving most logic into ViewControllers, but as there's currently lot's of other stuff open for review I stopped after "getting it somewhat in shape". As I did this for about an hour every week the last four weeks I lost a bit the overview about specific changes. Some are: * lots of coding style and bug changes regarding JS / ExtJS, to you excuse: the user panel you started this off isn't in good shape, so a lot can be explained by that. Also, now that we have 'eslint' packaged a lot of stuff can be checked and fixed automatically. * drop the "API Tokens" from the user menu, as it breaks stuff due to stacked windows (we normally don't do that) and z-index, also it felt a bit niche. * partly due to aforementioned dropping I now pre-select the logged in username when creating a new token * various other small UX and rendering stuff here and there There may still come a few followups later where we get into a bit more calm period, but for now it should do. Please test a bit around, not that I've missed something. Anyway, I much more happy with a working GUI prototype for new stuff (especially new API endpoints) than none at all - it shows that the API design was at least used in practice, not just theoretically - the latter one are almost always a PITA to use as fronted. And it wasn't to bad, some where also opinionated changes of mine ;) Thanks for this great feature! _______________________________________________ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
