On 4/21/20 4:38 PM, Stefan Reiter wrote:
On 21/04/2020 16:01, Dominik Csapak wrote:
netdev_add is now a proper qmp command, which means that it verifies
the parameter types properly
The patch looks reasonable, but I'm confused how that worked before?
'git blame' tells me the typed QMP schema for netdev_add has been in
QEMU since 2017..
yes but it changed recently (17. March 2020)
its commit:
db2a380c84574d8c76d7193b8af8535234fe5156
net: Complete qapi-fication of netdev_add
it changes netdev_add from
{ 'command': 'netdev_add',
'data': {'type': 'str', 'id': 'str'},
'gen': false } # so we can get the additional arguments
to
{ 'command': 'netdev_add', 'data': 'Netdev', 'boxed': true }
_______________________________________________
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
