On 4/9/20 2:18 PM, Fabian Ebner wrote:
>> +++ b/www/manager6/form/CompressionSelector.js
>> @@ -4,6 +4,7 @@ Ext.define('PVE.form.CompressionSelector', {
>> comboItems: [
>> ['0', Proxmox.Utils.noneText],
>> ['lzo', 'LZO (' + gettext('fast') + ')'],
>> - ['gzip', 'GZIP (' + gettext('good') + ')']
>> + ['gzip', 'GZIP (' + gettext('good') + ')'],
>> + ['zstd', 'ZSTD (' + gettext('better') + ')']
>
> Adding a comma after the last item will make the next patch touching this
> shorter ;). I found other places where we do that, so it should be fine, but
> I'm not too familiar with JavaScript so please correct me if I'm wrong.
Yes, trailing commas are now *wanted*, they weren't possible before
Proxmox VE 6 as then we still supported a Internet Explorer variant
which choked on them, that's why lots of older stuff doesn't has them.
But, please always add them for new stuff.
We'll soon add a linter again and enforce this.
_______________________________________________
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
