On 3/12/20 4:09 PM, Stoiko Ivanov wrote:
> Hi,
>
> Thanks for hunting this down so fast (and for sending a second version)!
>
> applied it locally - did some rough testing (also the part with specifying
> a netmask as dotted quad) (I could reproduce the issue on my network config
> before)
> Talked the code through with Dominik - seems sensible.
>
> FWIW:
> Reviewed-By: Stoiko Ivanov <s.iva...@proxmox.com>
> Tested-By: Stoiko Ivanov <s.iva...@proxmox.com>
much thanks for looking at this so quickly, with those tags: applied
>
> On Thu, 12 Mar 2020 15:49:07 +0100
> Thomas Lamprecht <t.lampre...@proxmox.com> wrote:
>
>> On 3/12/20 3:24 PM, Thomas Lamprecht wrote:
>>> + } elsif (my $mask =
>>> PVE::JSONSchema::get_netmask_bits("netmask$suffix")) {
>>
>> Obviously should be:
>>
>>> + } elsif (my $mask =
>>> PVE::JSONSchema::get_netmask_bits($d->{"netmask$suffix"})) {
>>
_______________________________________________
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
