On 2/25/20 11:28 AM, Dominic Jäger wrote: > Move wipe_disks from PVE::Ceph::Tools to PVE::Diskmanage and improve it by > - Handling invalid parameters > - Adding options for wiping > - Making names clearer, especially the sub name to indicate that it works for > partitions, too. > - Use `blockdev` system call because it is easier to understand > - Adding tests > > Relies on the corresponding patch in pve-manager. > > Signed-off-by: Dominic Jäger <d.jae...@proxmox.com> > --- > v1->v2: > - Fix typo > - Not only move the function but also improve it > > PVE/Diskmanage.pm | 63 ++++++++++++++++++++++++++++++++++++++ > test/disklist_test.pm | 71 +++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 134 insertions(+) >
Dominik, please take a look at this series, I'd like a R-b from you for this. _______________________________________________ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
