On 3/2/20 3:51 PM, Moayad Almalat wrote:
> Signed-off-by: Moayad Almalat <m.alma...@proxmox.com>
> ---
> src/PVE/LXC/Setup/CentOS.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/PVE/LXC/Setup/CentOS.pm b/src/PVE/LXC/Setup/CentOS.pm
> index cc4c5bb..34430ff 100644
> --- a/src/PVE/LXC/Setup/CentOS.pm
> +++ b/src/PVE/LXC/Setup/CentOS.pm
> @@ -20,7 +20,7 @@ sub new {
> my $version;
>
> if ($release =~ m/release\s+(\d+\.\d+)(\.\d+)?/) {
> - if ($1 >= 5 && $1 <= 8) {> + if ($1 >= 5 && $1 <= 8.1) {
This still wasn't really future proof as it did not followed Oguz suggestion to
allow everything <= 9, to ensure also the next point release does not provokes
the same issue again (stable centos releases stay pretty stable, so no point in
whitelisting each extra).
For backporting to stable branches I prefer doing cherry-picks, e.g., here I
just did:
git cherry-pick -xs c823eb0a1b2b04bc7745bbac4819be9a9c96df51
git cherry-pick -xs 78f2d64051326084038c4b0316d59f5fe4289d6f
and then squashed those two patches into one (Oguz made the same "mistake" as
you then when he fixed it for PVE 6, but it's enough if the commit message
reflects that, the two separate commits can be avoided).
Thanks nonetheless to bringing attention to this issue. Please try to follow
and adapt to reviews more closely. You can also decide to not do something
suggested but it should be clear why. Developer time is relatively cheap
compared to (good) reviewer time, so reviews should be taken seriously - just a
general note to all :)
thanks!
> $version = $1;
> }
> }
>
_______________________________________________
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
