On February 24, 2020 1:44 pm, Fabian Ebner wrote:
> Signed-off-by: Fabian Ebner <f.eb...@proxmox.com>
> ---
> PVE/Storage.pm | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/PVE/Storage.pm b/PVE/Storage.pm
> index 851c59d..8969d2e 100755
> --- a/PVE/Storage.pm
> +++ b/PVE/Storage.pm
> @@ -570,6 +570,7 @@ sub storage_migrate {
> my $ratelimit_bps = $opts->{ratelimit_bps};
> my $insecure = $opts->{insecure};
> my $with_snapshots = $opts->{with_snapshots} ? 1 : 0; # sanitize for
> passing as cli parameter
> + my $allow_rename = $opts->{allow_rename} ? 1 : 0; # sanitize for passing
> as cli parameter
single comment above the two would be enough. we use this pattern quite
often to co-erce bools into 1/0, so I am not even sure if we need a
comment at all..
>
> my ($storeid, $volname) = parse_volume_id($volid);
> my $target_volname = $opts->{target_volname} || $volname;
> @@ -618,6 +619,7 @@ sub storage_migrate {
> if ($migration_snapshot) {
> push @$recv, '-delete-snapshot', $snapshot;
> }
> + push @$recv, '-allow-rename', $allow_rename;
>
> if (defined($base_snapshot)) {
> # Check if the snapshot exists on the remote side:
> --
> 2.20.1
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@pve.proxmox.com
> https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
_______________________________________________
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
