On February 24, 2020 3:22 pm, Dominik Csapak wrote: > On 2/24/20 2:45 PM, Fabian Grünbichler wrote: >> On February 24, 2020 12:01 pm, Dominik Csapak wrote: >>> according to rfc 1034[0], each label of a domain name can be 63 octets >>> so increase that limit in the api calls and in ceph_service_cmd >>> >>> users can now create ceph services on machines with hostnames >>> longer than 32 characters >> >> why not have the same pattern like for monitor/.. creation? e.g., >> createmon has: >> >> pattern => '[a-zA-Z0-9]([a-zA-Z0-9\-]*[a-zA-Z0-9])?' >> >> unless I misread, MGR and MDS have the same pattern. >> > > mhmm.. i'd argue that is wrong too, since systemd has an upper > limit of 256 characters, including suffix (although > this is only mentioned in [0], not in my locally installed > manpages, so i am not sure how accurate it is)
I vaguely remembered something like this, checked the man page, and did not find anything ;) thanks for looking properly. > but i agree, we should use the same pattern in all places.. yes. > > suggestions? limit the ID/name part to 200 characters? probably more than any sane setup would use, and still far away from possibly hitting the 256 char limit. technically a breaking change for the create API path, but one that should not matter in practice. _______________________________________________ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
