On 2/10/20 11:20 AM, Thomas Lamprecht wrote:
On 2/5/20 12:00 PM, Dominik Csapak wrote:
sometimes, if users do not want a ipv4/6 address, they set the network mode
to 'dhcp' instead of 'static' (with no ip set), in believe
this will result in no ip

in reality, often no ipv6 dhcp server exists in the environment, and
the container start stalls for ~5min trying to get a ipv6

to improve ux, add the option 'none', which functionally is the same
as having selected 'static' with no ip set, and simultaniously
make the ip required

Signed-off-by: Dominik Csapak <d.csa...@proxmox.com>
---
changes from v1:
* make 'static' default for new nics (e.g. in the wizard)
* rename none4/6 to noIPv4/6Addr
* remove unnecessary comments
* use NoneText (this requires a new widget-toolkit with my other patch
   applied)

So, was about to applied it and tried it a bit out, which got me thinking a bit.
I'm not really sure anymore if this is the best approach.

Why don't we just use a sane emptyText for the "none" case.
This avoids two additional radio buttons (cluttering) while giving a user the
same feedback. Maybe, "No Address"?

What do you think?


mhmm.. yes would also work of course, altough it does not make the
distinction as clear as a seperate option (but i think its enough)
i'll send a v3 with an empty text

_______________________________________________
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Reply via email to