Patches 1-3 can be applied immediately, no dependency on anything else. The RFC patches only make sense together with my previously submitted cluster link series[0]. I'm anything but a GUI designer, so I'm happy for any feedback on the new CorosyncLinkEdit component - hence sending it now already.
A note on compatibility: The new component is fully backwards compatible with a join info from an older GUI version. This generally also works the other way, i.e. even patch 6 (which changes the join info) doesn't break an older GUI parsing it. However, if one has a cluster with more links other than 0/1, and creates a joinInfo using the new GUI, these will be in the info. Pasting this into an older GUI will 'work', in the sense that the GUI allows it, but a user obviously cannot select a network for any link other than 0/1, so the join itself fails. This *could* be changed, by renaming a component of the join info, thus older GUI versions would then report it as invalid (instead of only failing after clicking join). I personally think that behaviour would be more confusing than the current, but just as an idea, this is an RFC after all ;) [0] https://pve.proxmox.com/pipermail/pve-devel/2020-January/041168.html widget-toolkit: Stefan Reiter (1): ComboGrid: fix on-load validation for blank values form/ComboGrid.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) manager: Stefan Reiter (5): gui/cluster: validate cluster name length on create gui/cluster: show cluster name from joinInfo in join dialog gui/cluster: add CorosyncLinkEdit component to support up to 8 links gui/cluster: show all links (up to 8) in cluster overview gui/cluster: add structured peerLinks to join info www/manager6/Makefile | 1 + www/manager6/Utils.js | 10 + www/manager6/dc/Cluster.js | 133 +++++++-- www/manager6/dc/ClusterEdit.js | 170 +++++------ www/manager6/dc/CorosyncLinkEdit.js | 420 ++++++++++++++++++++++++++++ 5 files changed, 628 insertions(+), 106 deletions(-) create mode 100644 www/manager6/dc/CorosyncLinkEdit.js -- 2.20.1 _______________________________________________ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
