On 10/31/19 1:36 PM, Dominik Csapak wrote: > this series lets users add tags to guest configs > these do not have any concrete meaning but are intended to be used > by management software such as config management systems > > this is the basic implementation of this feature, in the next step > i want to do: > * get the tags in the /cluster/resources api > this way we could show it in the gui, but more important, we can > give the users a list of available tags to choose from in the selector > * maybe make the colors customizable, e.g. in the datacenter.cfg > where an admin could give specific colors to a certain tag > for instance: > tagcolors: production=255,255,0,1 > in rgba values, we could query that and use it in our 'hash' > function if the string exists in the custom color map > > changes from v2: > * rebase on master (drop applied patch, merge with lxc pending changes) > * move utilities to widget-toolkit > * prefix css classes > * remove tags from options and add edit button to the tags directly > * show 'no tags' when no tags are defined > * improve statusTxt style > > changes from v1: > * slightly different format (use [a-z...] instead of \w) > * add comment in JSONSchema > * better commit message > * add the tags to the status api call of guests (for gui) > * show the tags in the gui > * make the tags editable in the gui >
applied qemu-server and container, for the Webinterface part I'd like to see some changes/features.. * tag reordering (or show/save them sorted) * editing a specific single tag * tag edit window is pretty small and the UX is so lala, maybe one will accustom to it, but maybe it would be better to just have a list of tags (textfield or field-container) * collapse tags if there are more than X (e.g., >3 and/or configurable over browser settings), where the full list is then shown only on mouse-hover, as it gets crowded fast. * "No Tags" looks also a bit weird without visible separator, maybe just prepend fa-tags symbol with a tooltip? * an option to show them could also be the bottom of the VM/CT panel "vertical menu", as stack - just as idea. The colors are somewhat OK, I mean at first really not, but I got became accustomed to it pretty fast.. If such auto-coloring is chosen it will always stay in contrast/fight a bit with the colors of the theme, IMO.. I omit the gui patches for now, imo some refinement, would be good here. _______________________________________________ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
