On 10/28/19 12:47 PM, Dominic Jäger wrote: > Previously a VMID conflict was possible when creating a VM on another node > between locking the config with lock_config_full and writing to it for the > first time with write_config. > > Using create_and_lock_config eliminates this possibility. This means that now > the "lock" property is set in the config instead of using flock only. > > $param was empty when it was assigned the three values "name", "memory" and > "cores" before being assigned to $conf later on. Assigning those values > directly to $conf avoids confusion about what the two variables contain. > > Signed-off-by: Dominic Jäger <d.jae...@proxmox.com> > --- > v1->v2: > - Add note about $param in commit message > - Improve commit message, especially replacing "parameter lock" with "lock > config" > - Remove unnecessary semicolon in one-liner > - Adapted error message > - Use return early pattern > > PVE/CLI/qm.pm | 66 +++++++++++++++++++++++++-------------------------- > 1 file changed, 32 insertions(+), 34 deletions(-) >
applied, thanks! _______________________________________________ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
