On 10/25/19 11:24 AM, Dominic Jäger wrote:
> This function has been used in one place only. Removing it avoids confusion
> between vm_destroy and vm_destroy.
>
> Signed-off-by: Dominic Jäger <d.jae...@proxmox.com>
> ---
> I copied all the checks from vm_destroy even if they were useless.
> Removing those useless functions is a follow up patch.$
Hmm, I'd rather see 3/7 squashed into this, as the "single change" here
in that part of the series is rather the replacement of vm_destroy with
destroy_vm, moving API and CLI closer together.. So this intermediate
step is a bit confusing to me.
>
> PVE/CLI/qm.pm | 11 +++++++++--
> PVE/QemuServer.pm | 15 ---------------
> 2 files changed, 9 insertions(+), 17 deletions(-)
>
> diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm
> index ea74ad5..6405b42 100755
> --- a/PVE/CLI/qm.pm
> +++ b/PVE/CLI/qm.pm
> @@ -653,8 +653,15 @@ __PACKAGE__->register_method ({
>
> my $err = $@;
> if ($err) {
> - my $skiplock = 1;
I mean, it was here for readability, to tell people that we skip the lock,
instead of just passing an arbitrary 1 as method parameter. Granted, we do
that very often and people need to read the method implementation signature
most of the time anyway, so you may still do that.. See this rather a note
that it wasn't there out of mistake ^^
_______________________________________________
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
