On 10/14/19 10:28 AM, Oguz Bektas wrote: > this patch series makes it possible to add/delete/revert pending changes > in the backend for containers. > > v2 -> v3: > * reorder and squash/split commits > * split load_current_config and load_snapshot_config > * use perl hash representation for the pending delete hash > * remove semi-related stuff (i.e. namespacing snapshots, which i'll send > in another patch) > * add conf_table_with_pending guesthelper for the vm_pending API call > * move back $param checks to lxc API call instead of update_pct_config > * error handling for vmconfig_apply_pending > >
applied whole series, much thanks! So, for guest-common I made quite a few small followups, mostly coding style related (it's not always "fixing" yours, as often you just moved stuff around without real change, so no offense ;) ) To verify those, and to understand the series better in general I added a small test harness[0], basically the whole AbstractConfig can be unit tested, one can specify a method and then add input params and expected result, for that that it's really simple it's also quite flexible, IMO. [0]: https://git.proxmox.com/?p=pve-guest-common.git;a=blob;f=tests/abstract-config-tests.pl;h=db18c572ad41fd8cbe582f49a4aa6e7180335293;hb=6df4b6a8ea2897fd7574f74c2e46c1b6fb943527#l12 Anyway, some pve-conatiner, and qemu-server specific test could be great. Also verifying and adding to [0] wouldn't hurt. thanks for the effort, to both, you and Fabian! _______________________________________________ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
