why add a new, half-empty plugin instead of the full one? the whole file is < 100 lines if you remove the duplication with validating_url.. IMHO there are some commits that could be squashed here ;)
On October 14, 2019 1:08 pm, Wolfgang Link wrote: > --- > src/Makefile | 1 + > src/PVE/ACME.pm | 2 ++ > src/PVE/ACME/ACME_sh.pm | 24 ++++++++++++++++++++++++ > 3 files changed, 27 insertions(+) > create mode 100644 src/PVE/ACME/ACME_sh.pm > > diff --git a/src/Makefile b/src/Makefile > index 02f1f56..fcccac8 100644 > --- a/src/Makefile > +++ b/src/Makefile > @@ -10,6 +10,7 @@ LIB_SOURCES = \ > ACME.pm \ > ACME/Challenge.pm \ > ACME/StandAlone.pm \ > + ACME/ACME_sh.pm \ > AtomicFile.pm \ > Certificate.pm \ > CLIFormatter.pm \ > diff --git a/src/PVE/ACME.pm b/src/PVE/ACME.pm > index c82f297..d6b6e99 100644 > --- a/src/PVE/ACME.pm > +++ b/src/PVE/ACME.pm > @@ -19,6 +19,7 @@ use Crypt::OpenSSL::RSA; > > use PVE::ACME::Challenge; > use PVE::ACME::StandAlone; > +use PVE::ACME::ACME_sh; > > use PVE::Certificate; > use PVE::Tools qw( > @@ -28,6 +29,7 @@ file_get_contents > > Crypt::OpenSSL::RSA->import_random_seed(); > PVE::ACME::StandAlone->register(); > +PVE::ACME::ACME_sh->register(); > > my $LETSENCRYPT_STAGING = > 'https://acme-staging-v02.api.letsencrypt.org/directory'; > > diff --git a/src/PVE/ACME/ACME_sh.pm b/src/PVE/ACME/ACME_sh.pm > new file mode 100644 > index 0000000..57d4f54 > --- /dev/null > +++ b/src/PVE/ACME/ACME_sh.pm > @@ -0,0 +1,24 @@ > +package PVE::ACME::ACME_sh; > + > +use strict; > +use warnings; > + > +use HTTP::Daemon; > +use HTTP::Response; these are wrongly copy-pasted.. > + > +use base qw(PVE::ACME::Challenge); > + > +sub type { > + return 'acme_sh'; > +} > + > +sub supported_challenge_types { > + return 'dns-01'; > +} > + > +sub validating_url { > + my ($class, $acme, $auth, $auth_url, $node_config) = @_; > + > +} see comment for this in other places.. > + > +1; > -- > 2.20.1 > > > _______________________________________________ > pve-devel mailing list > pve-devel@pve.proxmox.com > https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > > _______________________________________________ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
