>>Wolfgang meant that it could make sense to split the sdn config up for >>controller, zones, and something else which I currently do not remember; >>we could place those then in a /etc/pve/sdn/ folder..
>>It would be still easy to do so now, not 100% sure though, maybe you >>have a better opinion (or Wolfgang can tell his without my forgetting >>brain in-between ;) ) Yes, I'm thinking about this too. Maybe splitting plugins too. (PVE/SDN/Transport/Plugin.pm , PVE/SDN/Controllers/Plugin.pm, PVE/SDN/Vnet.pm) My really first implementation was with seperate config for vnet && zones, but Dietmar would like to see if we can merge it as it was pretty simple at this time. But now with controllers, I need to add a property to known if it's a controller plugin, or a transport plugin or a vnet. So I think it should be better to split them. I'll work on this next week. Thanks for the review ! ----- Mail original ----- De: "Thomas Lamprecht" <t.lampre...@proxmox.com> À: "pve-devel" <pve-devel@pve.proxmox.com>, "aderumier" <aderum...@odiso.com> Envoyé: Jeudi 17 Octobre 2019 19:29:50 Objet: applied-series: [pve-devel] [PATCH pve-network 0/8] generic sdn controller plugins + improvments On 9/30/19 11:03 AM, Alexandre Derumier wrote: > This patch serie mainly rework the plugins to manage sdn controllers. > currently it was working with frr only, > now it's possible to define differents plugins for sdn controllers. > Frr specific code has been move to his own plugins too. > > For true sdn, we have 2 plugins, 1 for dataplane (switch/bridge setup), > 1 for controlplane (the controller). > (As we can have multiple dataplanes for 1 controller) > > > I have added a (not fully working yet) poc with faucet sdn controller plugin. > > I have made also split of some plugins (evpn,qinq) to their own plugins. > applied series, thanks! Wolfgang meant that it could make sense to split the sdn config up for controller, zones, and something else which I currently do not remember; we could place those then in a /etc/pve/sdn/ folder.. It would be still easy to do so now, not 100% sure though, maybe you have a better opinion (or Wolfgang can tell his without my forgetting brain in-between ;) ) > > Alexandre Derumier (8): > make sdn controller plugin generic > vxlan: move transport controller config to frrplugin > add faucet sdn controller plugins > add evpnplugin (splitted from vxlanplugin) > add controller_reload > rename plugins with controllers > add qinq plugin > api2 : sdn : add role and type to index > > PVE/API2/Network/SDN.pm | 18 +- > PVE/Network/SDN.pm | 180 +++++-------- > PVE/Network/SDN/EvpnControllerPlugin.pm | 313 ++++++++++++++++++++++ > PVE/Network/SDN/EvpnPlugin.pm | 200 ++++++++++++++ > PVE/Network/SDN/FaucetControllerPlugin.pm | 113 ++++++++ > PVE/Network/SDN/FaucetPlugin.pm | 76 ++++++ > PVE/Network/SDN/FrrPlugin.pm | 142 ---------- > PVE/Network/SDN/Makefile | 2 +- > PVE/Network/SDN/Plugin.pm | 19 +- > PVE/Network/SDN/QinQPlugin.pm | 81 ++++++ > PVE/Network/SDN/VlanPlugin.pm | 25 +- > PVE/Network/SDN/VnetPlugin.pm | 6 + > PVE/Network/SDN/VxlanPlugin.pm | 110 +------- > test/documentation.txt | 8 +- > test/generateconfig.pl | 10 +- > 15 files changed, 910 insertions(+), 393 deletions(-) > create mode 100644 PVE/Network/SDN/EvpnControllerPlugin.pm > create mode 100644 PVE/Network/SDN/EvpnPlugin.pm > create mode 100644 PVE/Network/SDN/FaucetControllerPlugin.pm > create mode 100644 PVE/Network/SDN/FaucetPlugin.pm > delete mode 100644 PVE/Network/SDN/FrrPlugin.pm > create mode 100644 PVE/Network/SDN/QinQPlugin.pm > _______________________________________________ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
