On 10/3/19 5:19 PM, Stefan Reiter wrote: > On 10/3/19 5:10 PM, Thomas Lamprecht wrote: >> On 10/3/19 4:56 PM, Stefan Reiter wrote: >>> "built-in", you have to explicitly set a value in the config to 0, which >>> looks >>> weird - basically "unsetting" something to use a feature), but I'm very much >>> fine with either. >> >> but it does not really needs to be set in the config at all, or? >> I mean you can set it when reading so it will be only a internal flag? >> > > Sorry should have clarified: I meant the VM config. E.g. <vmid>.conf: > > cpu: custom-name,built-in=0,flags=...
This is just a guard for the case where a custom defined model would get added into QEMU and having a switchable flag for this seems weird a wrong to me. I'd rather prefix the user configured models, e.g., with "custom-" or "pve-". _______________________________________________ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
