We are currently looking at a re-do of CPU models and flags in general, including adding support for custom CPU models [0]. Feature flags like aes would be automatically supported by this (i.e. you could create a custom model derived from kvm64 and add aes to it).

Then again, I'm not sure what will happen to the current way of selecting CPU flags, so it could still be worthwhile to merge this.

The patch itself looks good to me, although if we do decide to apply it now, I'd suggest adding in avx/avx2 as well.

~ Stefan

[0] https://pve.proxmox.com/pipermail/pve-devel/2019-July/038453.html

On 8/12/19 3:07 PM, Peter Keresztes Schmidt | SOSETH Internal Affairs wrote:
Hi,

is there anything missing before this and the corresponding pve-manager patch 
can be reviewed?

Regards,
Peter

_______________________________________________
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


_______________________________________________
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Reply via email to