On Mon, Jul 15, 2019 at 03:39:59PM +0200, Aaron Lauterer wrote: > On 7/15/19 3:07 PM, Fabian Grünbichler wrote: > > On Mon, Jul 15, 2019 at 02:37:45PM +0200, Aaron Lauterer wrote: > > > Found a missing possible missing comma > > > > > > On 7/15/19 11:35 AM, Fabian Grünbichler wrote: > > > > Signed-off-by: Fabian Grünbichler <f.gruenbich...@proxmox.com> > > > > --- > > > > system-booting.adoc | 3 ++- > > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/system-booting.adoc b/system-booting.adoc > > > > index c7f6534..fc8d896 100644 > > > > --- a/system-booting.adoc > > > > +++ b/system-booting.adoc > > > > @@ -79,7 +79,8 @@ system boots even if the first boot device fails. > > > > The ESPs are kept in sync by > > > > a kernel postinstall hook script > > > > `/etc/kernel/postinst.d/zz-pve-efiboot`. The > > > > script copies certain kernel versions and the initrd images to > > > > `EFI/proxmox/` > > > > on the root of each ESP and creates the appropriate config files in > > > > -`loader/entries/proxmox-*.conf`. > > > > +`loader/entries/proxmox-*.conf`. The `pve-efiboot-tool` script assists > > > > in > > > > +managing both synced ESPs themselves, and their contents. > > > > > > This might be nitpicky, but shouldn't there be a comma? > > > "managing both, synced ESPs themselves, and their contents." > > > > or no comma at all? :-P > > > > "managing both synced ESPs themselves and their contents." > > > > never been my strong suite, always miss adding them in German as well.. > > > > I am pretty sure that there should be a comma between "both" and "synced" as > "synced ESPs" and "their contents" is a list.
but one with only two elements, so no Oxford Comma here. it's not "foo, bar[,] and baz" but "both foo and bar". think "my breakfast consists of [both] coffee and tea" (if I want to emphasize that I drink TWO hot beverages in a single meal, just like the 'both' here emphasizes that the script manages two only slightly related things). I dropped the comma and added a 'the' in v2 before your mail :-P _______________________________________________ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
