On 7/2/19 3:17 PM, Oguz Bektas wrote:
> show a message on screen about memory requirement, then die and abort
> the installation.
>
> Signed-off-by: Oguz Bektas <o.bek...@proxmox.com>
> ---
> proxinstall | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/proxinstall b/proxinstall
> index e6a29b3..f8dd1d6 100755
> --- a/proxinstall
> +++ b/proxinstall
> @@ -3234,6 +3234,11 @@ sub create_intro_view {
>
> cleanup_view();
>
> + if (int($total_memory/1024) < 1) {
not that it matters much but:
> int($total_memory) < 1024
is:
* easier to read
* most of the time faster, (simple compare vs division + compare,
> + display_error("you need at least 1GB memory to install Proxmox\n");
> + die "not enough memory";
I do not want to die here, if one wants to continue, why not (e.g.,
the limit is not exactly 1024 but rather somewhere beteween 850-900
MB, and also then the error is IMO not reasonable, proxinstall +
gtk-webkit + base system need ~ 300 MB memory, and that the page
cache flushes result in memory almost OOM-like errors seems wrong.)
I mean, the check is still OK, as this is our min. system requirement,
and it does normally not make sense to install PVE/PMG to anything with
less memory, besides from testing :)
With followups minding above: applied
> + }
> +
> if ($setup->{product} eq 'pve') {
> eval {
> my $cpuinfo = file_get_contents('/proc/cpuinfo');
>
_______________________________________________
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
