On 6/14/19 3:37 PM, Alwin Antreich wrote: > This patch adds zstd for backup/restore. It also factors out the common > parts on the decompression tools. Sadly tar 1.31 (includes zstd) was not > available at the time of writing this patch. >
This does much more than I'm confortable with for such a subject. As said in other replies, please refactor out _first_ in such a way that it does not changes outside observable behavior in any way, then add zstd. I.e., first tidy up and make it nice, then reap the benefits by doing the addition of the new feature in a much more simple and smaller way. Maybe also pull out those whole regex definitions, also in a separate patch which should change nothing else. _______________________________________________ pve-devel mailing list [email protected] https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
