Thank you Thomas and Dominik for the feedback!
> Am 5/17/19 um 12:16 PM schrieb Dominik Csapak: > it is quite a bit of code, for not that much gain > I agree. My idea was to stick with the proposed solution in Bugzilla for the first patch. > and does not even prevent the problem if someone has many vms that > get backed up (or am i missing that bit?) > You are not missing it. Having too many VMs would still result in a rejected mail. > why hardcoded here? (...) > i would rather have them as parameter, so that someone can tune this (if > necessary) > As I was not sure where the most appropriate place for tuning this would be. Anyway, they are not needed anymore as I will send a patch with your two ideas a) > one approach i would favor is to generate the mail, check the size, > and only send the initial overview table with a notice that the > mail was too long and where to find the log > and b) > Thomas Lamprecht < t.lampre...@proxmox.com mailto:t.lampre...@proxmox.com > > hat am 17. Mai 2019 um 16:07 geschrieben: > next if $line =~ /^status: \d+/; > > would omit all status line, > With a lot of tests of course :) _______________________________________________ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
