[pve-devel] [PATCH manager v2] check for VM.Montior privileges on qemu AgentIPView

[Dominik Csapak]

so that the user does not get the useless 'no information' or
'not running' message, but the real cause

Signed-off-by: Dominik Csapak <d.csa...@proxmox.com>
---
changes from v1:
* use a better gettext for the error message
 www/manager6/qemu/AgentIPView.js | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/www/manager6/qemu/AgentIPView.js b/www/manager6/qemu/AgentIPView.js
index ecc091f1..179b2922 100644
--- a/www/manager6/qemu/AgentIPView.js
+++ b/www/manager6/qemu/AgentIPView.js
@@ -128,15 +128,23 @@ Ext.define('PVE.qemu.AgentIPView', {
        me.running = (store.getById('status').data.value === 'running');
        /*jslint confusion: false*/
 
+       var caps = Ext.state.Manager.get('GuiCap');
+
+       if (!caps.vms['VM.Monitor']) {
+           var errorText = gettext("Requires '{0}' Privileges");
+           me.updateStatus(false, Ext.String.format(errorText, 'VM.Monitor'));
+           return;
+       }
+
        if (me.agent && me.running && me.ipStore.isStopped) {
            me.ipStore.startUpdate();
        }
        me.updateStatus();
     },
 
-    updateStatus: function(unsuccessful) {
+    updateStatus: function(unsuccessful, defaulttext) {
        var me = this;
-       var text = gettext('No network information');
+       var text = defaulttext || gettext('No network information');
        var more = false;
        if (unsuccessful) {
            text = gettext('Guest Agent not running');
-- 
2.11.0


_______________________________________________
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel