On 4/30/18 8:35 AM, Fabian Grünbichler wrote: > On Fri, Apr 27, 2018 at 03:38:26PM +0200, Thomas Lamprecht wrote: >> On 4/19/18 2:01 PM, Fabian Grünbichler wrote: >>> >>> +package PVE::ACME::StandAlone::Server; >>> + >>> +use HTTP::Server::Simple::CGI; >>> +use base qw(HTTP::Server::Simple::CGI); >> >> needs a new dependency on libhttp-server-simple-perl ... >> >> We depend already on libwww-perl here (and access-control and apiclient), >> which also provides a server module AFAIK. >> >> Maybe it would be nicer to reuse this, if possible? > > yes, like I mentioned in v1, this can be switched out for any other > "serve content $foo under path $bar" HTTP server implementation. >
Ah yes, then there's really no reason to pull in another new dependency ;) > I'll take a stab at implementing it with HTTP::Daemon :) > Perfect! Then I wait for a new 3/4, the other common related patches look OK, I'll push them all together once I get the 3/4 v3. _______________________________________________ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
