On 09/26/2017 02:01 PM, Wolfgang Bumiller wrote: > Rebase/redo of the old series. Note that I don't see the need to keep > read_password() wrapping an implementation method in all 3 CLI tools > when currently they all need to do the same thing. The only thing this > did was pass a name to the ReadLine ctor which is not all that useful. > If no verification is desired, you can still replace the method in a > derived class and call the CLIHandler's version with modified > parameters. > > Changes: > - Removed read_password() from pct and pveum entirely. > - Providing a default read_password() implementation in CLIHandler. > - Disable the access to and recording of history in the readline > instance rather than deleting the entries afterwards. > - Include the libterm-readline-gnu-perl dependency in pve-common (as it > was previously only in pve-manager). > > Wolfgang Bumiller (1): > CLIHandler: add a default read_password implementation > pct: remove read_password > pveum: remove read_password > pvesh: use the CLIHandler's read_password >
I skimmed over this series and it looks OK. I would really like to see this applied as I need such a method too, for the CLI part of the cluster-over-API setup, and I really do not want to add another semi-identical duplication of this. As the Debian control file of pve-common saw some cleanup since this was posted, this would need to be rebased, though. Do you (or Fabian, if he wants to apply it straight away :) have time for that, or should I pick this up? _______________________________________________ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
