On 09/26/2017 02:42 PM, Wolfgang Bumiller wrote:
Changes: Patch 2: * Fixed unmount warnings to refer to the right $src vs $dest variable.Patch 4 is new. Patch 5 (previous 4): * Instead of refusing moves when any snapshots exist, use the new 'is_volume_in_use' variant to check whether the volume is actually used in a snapshot, in which case we simply don't allow the --delete parameter. * Don't use both 'disk' and 'volume' in the parameter descriptions. * - Let the config key be referred to as $mpkey instead of $volume, - its parsed data s $mpdata - the actual storage volumes only as $old_volid and $new_volid instead of mixing $mp, $mp->{volume}, $volume, etc. in confusing ways.
I tested a bit around with LVM-thin, ZFS, NFS as backing storage. I did not run into anything problematic yet. The code looks OK to me, but I'm not to much into this topic for a real in-depth review so I may have missed something.
Wolfgang Bumiller (5): factor out disk allocation+formatting for reuse implement copy_volume use copy_volume for full clones config: is_volume_in_use: ability to search only snapshots add move_volume api call src/PVE/API2/LXC.pm | 179 ++++++++++++++++++++++++++++++++++++++++++++++---- src/PVE/CLI/pct.pm | 1 + src/PVE/LXC.pm | 151 +++++++++++++++++++++++++++++++++--------- src/PVE/LXC/Config.pm | 4 +- 4 files changed, 291 insertions(+), 44 deletions(-)
_______________________________________________ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
