On 09/05/2017 11:46 AM, Alexandre Derumier wrote:
We only use it to send commands faster like resume


nitpick: could you move the v2 in the tag at the start, i.e.:
[PATCH v2]
else this stays in the commit message and thus in git history,
where it does not belongs.
git format-patch can add this when using the -v<N> flag
if you just use send-email, without format-patch then you can also
add it there, e.g.:
# git send-email -s -v2 origin/master

That said, looks now OK to me, tested and reviewed.

Signed-off-by: Alexandre Derumier <aderum...@odiso.com>
---
  PVE/QemuMigrate.pm | 6 +++++-
  1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm
index fc847cc..5e18520 100644
--- a/PVE/QemuMigrate.pm
+++ b/PVE/QemuMigrate.pm
@@ -601,8 +601,9 @@ sub phase2 {
die "unable to detect remote migration address\n" if !$raddr; + $self->log('info', "start remote tunnel");
+
      if ($migration_type eq 'secure') {
-       $self->log('info', "start remote tunnel");
if ($ruri =~ /^unix:/) {
            unlink $raddr;
@@ -635,6 +636,9 @@ sub phase2 {
        } else {
            die "unsupported protocol in migration URI: $ruri\n";
        }
+    } else {
+       #fork tunnel for insecure migration, to send faster commands like resume
+       $self->{tunnel} = $self->fork_tunnel();
      }
my $start = time();



_______________________________________________
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Reply via email to