Re: [pve-devel] [PATCH manager 06/10] Use the noVirtiIO ControllerSelector property to build the list of controllers

[Dominik Csapak]

On 09/06/2017 10:15 AM, Emmanuel Kasper wrote:
---
  www/manager6/form/ControllerSelector.js | 7 ++-----
  1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/www/manager6/form/ControllerSelector.js 
b/www/manager6/form/ControllerSelector.js
index 15023a7a..5c6631b3 100644
--- a/www/manager6/form/ControllerSelector.js
+++ b/www/manager6/form/ControllerSelector.js
@@ -61,9 +61,9 @@ Ext.define('PVE.form.ControllerSelector', {
        var bussel = me.down('field[name=controller]');
        var deviceid = me.down('field[name=deviceid]');
  
-	if (autoSelect === 'cdrom') {
+       if (me.noVirtiIO) {

here you introduce a typo, which gets corrected in the next patch, so if 
the whole series gets applied, it is ok from my side

has anybody a different opinion on this?

            clist = ['ide', 'scsi', 'sata'];
-           if (!Ext.isDefined(me.vmconfig.ide2)) {
+           if (autoSelect === 'cdrom' && !Ext.isDefined(me.vmconfig.ide2)) {
                bussel.setValue('ide');
                deviceid.setValue(2);
                return;
@@ -76,9 +76,6 @@ Ext.define('PVE.form.ControllerSelector', {
  
  	Ext.Array.each(clist, function(controller) {
            var confid, i;
-           if (controller === 'virtio' && me.noVirtIO) {
-               return; //continue
-           }
            bussel.setValue(controller);
            for (i = 0; i <= PVE.form.ControllerSelector.maxIds[controller]; 
i++) {
                confid = controller + i.toString();



_______________________________________________
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel