Hi, >>I have found out that live resize is not possible since the LUN needs to >>be re-exposed for the OS to see the new size. Re-exposing causing VM to >>crash. So I bail if $running is true.
it should work if you send qmp block_resize command to vm, after resize the lun on the host. ----- Mail original ----- De: "datanom.net" <m...@datanom.net> À: "pve-devel" <pve-devel@pve.proxmox.com> Envoyé: Jeudi 8 Juin 2017 11:58:59 Objet: Re: [pve-devel] FreeNAS plugin: Status On 2017-06-08 09:31, Fabian Grünbichler wrote: > > no, IMHO this should work. I think the problem is (this time almost > certainly ;)) the colon. the path is just quoted using > PVE::Tools::shellquote, which is a wrapper around > String::ShellQuote::shell_quote. Similarly, PVE::Tools::run_command > will > us shellquote, but of course does not know about the semantics of the > command which is run, so cannot decide magically whether to encode > certain special characters which are not problematic for the shell > itself. > I have found out that live resize is not possible since the LUN needs to be re-exposed for the OS to see the new size. Re-exposing causing VM to crash. So I bail if $running is true. > if the "device" string of a call to "mount" contains a ':', its > autodetection seems to think you are trying to mount an NFS export > (where the ':' is the demarkation between server and export). > Sounds like a good explanation. > did you test whether anything breaks when your plugin's path method > escapes the colons? > No. Any other place it works fine. > > possibly same as above - or are you recreating the device when resizing > in your plugin? because there is a call to activate_volumes a few lines > above the call to PVE::Storage::volume_resize in PVE::API2::LXC's > resize_vm API path? > For the FreeNAS plugin disks (LUNs) are only exposed when the VM is running so any disk will only be exposed after calling activate_volume. Since volume_resize implicitly activates and deactivates the LUN for the remote OS to notice changes I need to activate it again before e2fsck and resize2fs on the volume is called since e2fsck and resize2fs are executed on the client. -- Hilsen/Regards Michael Rasmussen Get my public GnuPG keys: michael <at> rasmussen <dot> cc http://pgp.mit.edu:11371/pks/lookup?op=get&search=0xD3C9A00E mir <at> datanom <dot> net http://pgp.mit.edu:11371/pks/lookup?op=get&search=0xE501F51C mir <at> miras <dot> org http://pgp.mit.edu:11371/pks/lookup?op=get&search=0xE3E80917 -------------------------------------------------------------- ---- This mail was virus scanned and spam checked before delivery. This mail is also DKIM signed. See header dkim-signature. _______________________________________________ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel _______________________________________________ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
