On 04/26/2017 08:06 AM, Fabian Grünbichler wrote:
On Tue, Apr 25, 2017 at 03:45:58PM +0200, Thomas Lamprecht wrote:
This was part of the VM backup process before VMA was introduced, so I guess
it's safe to remove.
maybe it would make sense to drop the VM .tar backup restore for 5.x?
that would mean we could also remove the sparsecp binary and qmextract
script and simplify some of the restore code..
in general +1
extracting the backup content manually from such old archives is easy
enough (it is just a tar archive with the config, a device map and raw
disk images IIUC?)
VMA was introduced in Proxmox VE 2.3, released on 04.03.2013 over 4
years ago.
So while this is a long time I can see still the possibility for backups
lingering around.
So I would just delete it, but maybe split out the relevant code in a
own small executable
for legacy reasons and then remove it from the qmrestore and clean that up.
We probably do not even need sparsecp anymore, `cp --sparse=always`
should work also?
_______________________________________________
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
