On 02/22/2017 11:12 AM, Dominik Csapak wrote:
> the logic was reversed, checking writecache enabled 'nowritecache',
> now the logic is correct, setting 'nowritecache' if 'writecache' is
> unchecked
>
> Signed-off-by: Dominik Csapak <d.csa...@proxmox.com>
> ---
> i think this is a better and more elegant approach to the patch from
> m...@datanom.net, and still has the same functionality
>
> www/manager6/storage/ZFSEdit.js | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/www/manager6/storage/ZFSEdit.js b/www/manager6/storage/ZFSEdit.js
> index 12d6af1..094aa6a 100644
> --- a/www/manager6/storage/ZFSEdit.js
> +++ b/www/manager6/storage/ZFSEdit.js
> @@ -91,8 +91,9 @@ Ext.define('PVE.storage.ZFSInputPanel', {
> {
> xtype: 'pvecheckbox',
> name: 'nowritecache',
> - checked: true,
> - uncheckedValue: 0,
> + checked: false,
> + uncheckedValue: 1,
> + inputValue: 0,
> fieldLabel: gettext('Write cache')
> },
> {
looks good to me
IMHO, using framework facilities here allows to keep us a smaller code base
_______________________________________________
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
