Rebased and cleaned up W.Link's clone/move disk patches which have been sitting around for way too long now.
Differences are: * removed code which used the raw Storage::vdisk_alloc and called mkfs on non-subvols in favor of factoring out the allocate+mkfs code from create_disks() into a separate function. * improved handling of error cases in copy_volume() and dropped parameter for old vmid since we don't need that anymore * using a "move-disk" config-lock during the move disk operation instead of holding the file lock - we should do this for clone-disk and in qemu as well probably? * reordered move_volume CLI arguments to be consistent with qemu * improved some error messages * dropped the patch to implicitly create a snapshot in clone-vm since we don't do this automatically with qemu either * not removing the experimental flag yet, waiting for reviews first, and this should be done together with removing it from the 'template' call Wolfgang Bumiller (4): factor out disk allocation+formatting for reuse implement copy_volume use copy_volume for full clones add move_volume api call src/PVE/API2/LXC.pm | 174 ++++++++++++++++++++++++++++++++++++++++++++++++---- src/PVE/CLI/pct.pm | 1 + src/PVE/LXC.pm | 151 +++++++++++++++++++++++++++++++++++---------- 3 files changed, 284 insertions(+), 42 deletions(-) -- 2.1.4 _______________________________________________ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
