Hi, first thanks for the contribution! Not commenting on the code itself but we need a CLA for being able to add your contributions,
we use the Harmony CLA, a community-centered CLA for FOSS projects,
see https://pve.proxmox.com/wiki/Developer_Documentation#Software_License_and_Copyright

Also I would suggest using git format-patch and git send-email for sending the patch to the mailing list, so it is ensured that it can be applied here without problems. A small example of the necessary commands can be found at https://pve.proxmox.com/wiki/Developer_Documentation#Git_commands_summary

Cheers,
Thomas


On 07/26/2016 01:29 PM, Eneko Lacunza wrote:
Hi,

I just tested this patch to work as well as the previous one. Instead of setting rbd_cache_writethrough_until_flush=false in devfn, issue a bogus flush so that Ceph activated rbd cache.

---
Index: b/vma.c
===================================================================
--- a/vma.c
+++ b/vma.c
@@ -335,6 +335,9 @@ static int extract_content(int argc, cha

            BlockDriverState *bs = blk_bs(blk);

+ /* This is needed to activate rbd cache (writeback/coalesce) */
+            bdrv_flush(bs);
+
if (vma_reader_register_bs(vmar, i, bs, write_zero, &errp) < 0) {
                 g_error("%s", error_get_pretty(errp));
             }




_______________________________________________
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Reply via email to