>>Why is `bridge_add_interface` now restricted to the firewall-else >>branch?
I manage it like openvswitch, vlan tagging is always done on the main bridge, not firewall bridge. > + if ($firewall) { > + &$create_firewall_bridge_linux($iface, $bridge, $tag); create_firewall_bridge_linux($iface, $bridge, $tag) have - &$bridge_add_interface($bridge, $vethfwpeer); + &$bridge_add_interface($bridge, $vethfwpeer, $tag); #tag on the main bridge - return $fwbr; + &$bridge_add_interface($fwbr, $iface); # add vm tap interface on fwbridge without vlan tag ----- Mail original ----- De: "Wolfgang Bumiller" <w.bumil...@proxmox.com> À: "aderumier" <aderum...@odiso.com> Cc: "pve-devel" <pve-devel@pve.proxmox.com> Envoyé: Vendredi 24 Juillet 2015 15:20:06 Objet: Re: [pve-devel] [PATCH] tap_plug : add support for vlan aware linux bridge On Fri, Jul 24, 2015 at 01:52:59PM +0200, Alexandre Derumier wrote: > - $newbridge = &$create_firewall_bridge_linux($iface, $newbridge) if > $firewall; > + if (!$vlan_aware) { > + my $newbridge = activate_bridge_vlan($bridge, $tag); > + copy_bridge_config($bridge, $newbridge) if $bridge ne $newbridge; > + $tag = undef; > + } > + > + if ($firewall) { > + &$create_firewall_bridge_linux($iface, $bridge, $tag); > + } else { > + &$bridge_add_interface($bridge, $iface, $tag); > + } > > - &$bridge_add_interface($newbridge, $iface); Why is `bridge_add_interface` now restricted to the firewall-else branch? _______________________________________________ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel