>>Wouldn't it be better to do it inside print_drive_full?
Well,
print_drive_full already take format option from @qemu_drive_options
foreach my $o (@qemu_drive_options) {
next if $o eq 'bootindex';
$opts .= ",$o=$drive->{$o}" if $drive->{$o};
}
and format is already defined in parse_drive when it's a file with extension.
It seem the right place to do it ?
----- Mail original -----
De: "dietmar" <diet...@proxmox.com>
À: "aderumier" <aderum...@odiso.com>, "pve-devel" <pve-devel@pve.proxmox.com>
Envoyé: Mercredi 10 Juin 2015 06:57:03
Objet: Re: [pve-devel] [PATCH] parse_drive : set default format=raw if !cdrom
or no file extension
I mean parse_drive is not really the right location to fix that bug.
Wouldn't it be better to do it inside print_drive_full?
> Why do we need that?
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@pve.proxmox.com
> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
_______________________________________________
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
