> I wonder if we could replace qmp "snapshot-drive" (from > internal-snapshot-async.patch) > > by upstream qemu qmp method > > blockdev-snapshot-internal-sync > > http://git.qemu.org/?p=qemu.git;a=blob_plain;f=qmp-commands.hx;hb=HEAD > > One advantage is that multiple drive can be snapshotted in a transaction. > > from history we have done this snapshot-drive because no method existed at > this time. > > I think we just need to keep savevm_start, savevm_stop from > internal-snapshot-async.patch, > to be able to save the vmstate to external file/volume.
So we still need the code to save the state asynchronously "process_savevm_co", and also the code to load it "load_state_from_blockdev". So this would just remove a few line of very simple code in qmp_snapshot_drive? And we still need to handle external snapshots, so we do not gain much from that "multiple drive can be snapshotted in a transaction" feature (we just need to add more special cases, which make code more complex)? _______________________________________________ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
